Commit 8e552e53 authored Jul 30, 2013 by Yonghua Zheng Committed by Jiri Kosina Jul 31, 2013

HID: hidraw: fix improper mutex release



Mutex can not be released unless all hid_device members are properly
initialized. Otherwise it would result in a race condition that can
cause NULL pointer kernel panic issue in hidraw_open where it uses
uninitialized 'list' member in list_add_tail().

Signed-off-by: Yonghua Zheng <younghua.zheng@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>

parent 6f498018

drivers/hid/hidraw.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -518,7 +518,6 @@ int hidraw_connect(struct hid_device *hid)
		goto out;
		}

		mutex_unlock(&minors_lock);
		init_waitqueue_head(&dev->wait);
		INIT_LIST_HEAD(&dev->list);

		@@ -528,6 +527,7 @@ int hidraw_connect(struct hid_device *hid)
		dev->exist = 1;
		hid->hidraw = dev;

		mutex_unlock(&minors_lock);
		out:
		return result;