Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8e4b8246 authored by Sanskriti Sharma's avatar Sanskriti Sharma Committed by Greg Kroah-Hartman
Browse files

perf tools: Free temporary 'sys' string in read_event_files() 



[ Upstream commit 1e44224fb0528b4c0cc176bde2bb31e9127eb14b ]

For each system in a given pevent, read_event_files() reads in a
temporary 'sys' string.  Be sure to free this string before moving onto
to the next system and/or leaving read_event_files().

Fixes the following coverity complaints:

  Error: RESOURCE_LEAK (CWE-772):

  tools/perf/util/trace-event-read.c:343: overwrite_var: Overwriting
  "sys" in "sys = read_string()" leaks the storage that "sys" points to.

  tools/perf/util/trace-event-read.c:353: leaked_storage: Variable "sys"
  going out of scope leaks the storage it points to.

Signed-off-by: default avatarSanskriti Sharma <sansharm@redhat.com>
Reviewed-by: default avatarJiri Olsa <jolsa@kernel.org>
Cc: Joe Lawrence <joe.lawrence@redhat.com>
Link: http://lkml.kernel.org/r/1538490554-8161-6-git-send-email-sansharm@redhat.com


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c2128082

tools/perf/util/trace-event-read.c

+4 −1
Original line number Diff line number Diff line
@@ -349,10 +349,13 @@ static int read_event_files(struct tep_handle *pevent) 
		for (x=0; x < count; x++) {

			size = read8(pevent);

			ret = read_event_file(pevent, sys, size);

			if (ret)

			if (ret) {

				free(sys);

				return ret;

			}

		}

		free(sys);

	}

	return 0;

}