Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8e37e1a2 authored by Alex Shi's avatar Alex Shi Committed by Rafael J. Wysocki
Browse files

cpuidle/menu: stop seeking deeper idle if current state is deep enough 



Obsolete commit 71abbbf8 (cpuidle: extend cpuidle and menu governor
to handle dynamic states) wanted to introduce dynamic C-states, but that
idea was dropped long ago.  The nonsense deeper C-state checking
remained, though.

Since both target_residency and exit_latency are longer for deeper
idle state, there's no need to waste CPU time on useless checks.

Signed-off-by: default avatarAlex Shi <alex.shi@linaro.org>
Acked-by: default avatarRik van Riel <riel@redhat.com>
[ rjw: Subject & changelog ]
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 2dc8ffad

drivers/cpuidle/governors/menu.c

+2 −2
Original line number Diff line number Diff line
@@ -357,9 +357,9 @@ static int menu_select(struct cpuidle_driver *drv, struct cpuidle_device *dev) 
		if (s->disabled || su->disable)

			continue;

		if (s->target_residency > data->predicted_us)

			continue;

			break;

		if (s->exit_latency > latency_req)

			continue;

			break;



		data->last_state_idx = i;

	}