Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8ded5941 authored by Marek Szyprowski's avatar Marek Szyprowski Committed by Inki Dae
Browse files

drm/exynos: ipp: Remove Exynos DRM IPP subsystem 



Exynos DRM IPP subsystem is in fact non-functional and frankly speaking
dead-code. This patch clearly marks that Exynos DRM IPP subsystem is
broken and never really functional. It will be replaced by a completely
rewritten API.

Exynos DRM IPP user-space API can be obsoleted for the following
reasons:

1. Exynos DRM IPP user-space API can be optional in Exynos DRM, so
userspace should not rely that it is always available and should have
a software fallback in case it is not there.

2. The only mode which was initially semi-working was memory-to-memory
image processing. The remaining modes (LCD-"writeback" and "output")
were never operational due to missing code (both in mainline and even
vendor kernels).

3. Exynos DRM IPP mainline user-space API compatibility for
memory-to-memory got broken very early by commit 083500ba ("drm:
remove DRM_FORMAT_NV12MT", which removed the support for tiled formats,
the main feature which made this API somehow useful on Exynos platforms
(video codec that time produced only tiled frames, to implement xvideo
or any other video overlay, one has to de-tile them for proper
display).

4. Broken drivers. Especially once support for IOMMU has been added,
it revealed that drivers don't configure DMA operations properly and in
many cases operate outside the provided buffers trashing memory around.

5. Need for external patches. Although IPP user-space API has been used
in some vendor kernels, but in such cases there were additional patches
applied (like reverting mentioned 083500ba patch) what means that
those userspace apps which might use it, still won't work with the
mainline kernel version.

We don't have time machines, so we cannot change it, but Exynos DRM IPP
extension should never have been merged to mainline in that form.

Exynos IPP subsystem and user-space API will be rewritten, so remove
current IPP core code and mark existing drivers as BROKEN.

Signed-off-by: default avatarMarek Szyprowski <m.szyprowski@samsung.com>
Acked-by: default avatarDaniel Stone <daniels@collabora.com>
Acked-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: default avatarInki Dae <inki.dae@samsung.com>
parent ca52c712

drivers/gpu/drm/exynos/Kconfig

+3 −8
Original line number Diff line number Diff line
@@ -95,26 +95,21 @@ config DRM_EXYNOS_G2D 
	help

	  Choose this option if you want to use Exynos G2D for DRM.



config DRM_EXYNOS_IPP

	bool "Image Post Processor"

	help

	  Choose this option if you want to use IPP feature for DRM.



config DRM_EXYNOS_FIMC

	bool "FIMC"

	depends on DRM_EXYNOS_IPP && MFD_SYSCON

	depends on BROKEN && MFD_SYSCON

	help

	  Choose this option if you want to use Exynos FIMC for DRM.



config DRM_EXYNOS_ROTATOR

	bool "Rotator"

	depends on DRM_EXYNOS_IPP

	depends on BROKEN

	help

	  Choose this option if you want to use Exynos Rotator for DRM.



config DRM_EXYNOS_GSC

	bool "GScaler"

	depends on DRM_EXYNOS_IPP && ARCH_EXYNOS5 && VIDEO_SAMSUNG_EXYNOS_GSC=n

	depends on BROKEN && ARCH_EXYNOS5 && VIDEO_SAMSUNG_EXYNOS_GSC=n

	help

	  Choose this option if you want to use Exynos GSC for DRM.

drivers/gpu/drm/exynos/Makefile

+0 −1
Original line number Diff line number Diff line
@@ -18,7 +18,6 @@ exynosdrm-$(CONFIG_DRM_EXYNOS_MIXER) += exynos_mixer.o 
exynosdrm-$(CONFIG_DRM_EXYNOS_HDMI)	+= exynos_hdmi.o

exynosdrm-$(CONFIG_DRM_EXYNOS_VIDI)	+= exynos_drm_vidi.o

exynosdrm-$(CONFIG_DRM_EXYNOS_G2D)	+= exynos_drm_g2d.o

exynosdrm-$(CONFIG_DRM_EXYNOS_IPP)	+= exynos_drm_ipp.o

exynosdrm-$(CONFIG_DRM_EXYNOS_FIMC)	+= exynos_drm_fimc.o

exynosdrm-$(CONFIG_DRM_EXYNOS_ROTATOR)	+= exynos_drm_rotator.o

exynosdrm-$(CONFIG_DRM_EXYNOS_GSC)	+= exynos_drm_gsc.o

drivers/gpu/drm/exynos/exynos_drm_drv.c

+0 −12
Original line number Diff line number Diff line
@@ -29,7 +29,6 @@ 
#include "exynos_drm_plane.h"

#include "exynos_drm_vidi.h"

#include "exynos_drm_g2d.h"

#include "exynos_drm_ipp.h"

#include "exynos_drm_iommu.h"



#define DRIVER_NAME	"exynos"
@@ -109,14 +108,6 @@ static const struct drm_ioctl_desc exynos_ioctls[] = { 
			DRM_AUTH | DRM_RENDER_ALLOW),

	DRM_IOCTL_DEF_DRV(EXYNOS_G2D_EXEC, exynos_g2d_exec_ioctl,

			DRM_AUTH | DRM_RENDER_ALLOW),

	DRM_IOCTL_DEF_DRV(EXYNOS_IPP_GET_PROPERTY, exynos_drm_ipp_get_property,

			DRM_AUTH | DRM_RENDER_ALLOW),

	DRM_IOCTL_DEF_DRV(EXYNOS_IPP_SET_PROPERTY, exynos_drm_ipp_set_property,

			DRM_AUTH | DRM_RENDER_ALLOW),

	DRM_IOCTL_DEF_DRV(EXYNOS_IPP_QUEUE_BUF, exynos_drm_ipp_queue_buf,

			DRM_AUTH | DRM_RENDER_ALLOW),

	DRM_IOCTL_DEF_DRV(EXYNOS_IPP_CMD_CTRL, exynos_drm_ipp_cmd_ctrl,

			DRM_AUTH | DRM_RENDER_ALLOW),

};



static const struct file_operations exynos_drm_driver_fops = {
@@ -256,9 +247,6 @@ static struct exynos_drm_driver_info exynos_drm_drivers[] = { 
		DRV_PTR(rotator_driver, CONFIG_DRM_EXYNOS_ROTATOR),

	}, {

		DRV_PTR(gsc_driver, CONFIG_DRM_EXYNOS_GSC),

	}, {

		DRV_PTR(ipp_driver, CONFIG_DRM_EXYNOS_IPP),

		DRM_VIRTUAL_DEVICE

	}, {

		&exynos_drm_platform_driver,

		DRM_VIRTUAL_DEVICE

drivers/gpu/drm/exynos/exynos_drm_drv.h

+0 −2
Original line number Diff line number Diff line
@@ -188,7 +188,6 @@ struct exynos_drm_g2d_private { 


struct drm_exynos_file_private {

	struct exynos_drm_g2d_private	*g2d_priv;

	struct device			*ipp_dev;

};



/*
@@ -291,6 +290,5 @@ extern struct platform_driver g2d_driver; 
extern struct platform_driver fimc_driver;

extern struct platform_driver rotator_driver;

extern struct platform_driver gsc_driver;

extern struct platform_driver ipp_driver;

extern struct platform_driver mic_driver;

#endif

drivers/gpu/drm/exynos/exynos_drm_ipp.c

deleted100644 → 0
+0 −1806

File deleted.

Preview size limit exceeded, changes collapsed.