Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8d83bbd1 authored by Tomi Valkeinen's avatar Tomi Valkeinen
Browse files

drm/omap: print an error if display enable fails 



If the panel's enable fails, omap_encoder silently ignores the failure.
omapdrm should really handle the failure, but unfortunately the whole
encoder enable codepath is expected to always succeed.

So for now, catch the enable failure and print an error.

Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
parent a3d6345d

drivers/gpu/drm/omapdrm/omap_encoder.c

+6 −1
Original line number Diff line number Diff line
@@ -139,11 +139,16 @@ static void omap_encoder_enable(struct drm_encoder *encoder) 
	struct omap_encoder *omap_encoder = to_omap_encoder(encoder);

	struct omap_dss_device *dssdev = omap_encoder->dssdev;

	struct omap_dss_driver *dssdrv = dssdev->driver;

	int r;



	omap_encoder_update(encoder, omap_crtc_channel(encoder->crtc),

			    omap_crtc_timings(encoder->crtc));



	dssdrv->enable(dssdev);

	r = dssdrv->enable(dssdev);

	if (r)

		dev_err(encoder->dev->dev,

			"Failed to enable display '%s': %d\n",

			dssdev->name, r);

}



static int omap_encoder_atomic_check(struct drm_encoder *encoder,