Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8d74e9f8 authored by Willem de Bruijn's avatar Willem de Bruijn Committed by David S. Miller
Browse files

net: avoid skb_warn_bad_offload on IS_ERR 



skb_warn_bad_offload warns when packets enter the GSO stack that
require skb_checksum_help or vice versa. Do not warn on arbitrary
bad packets. Packet sockets can craft many. Syzkaller was able to
demonstrate another one with eth_type games.

In particular, suppress the warning when segmentation returns an
error, which is for reasons other than checksum offload.

See also commit 36c92474 ("net: WARN if skb_checksum_help() is
called on skb requiring segmentation") for context on this warning.

Signed-off-by: default avatarWillem de Bruijn <willemb@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c9f1f58d

net/core/dev.c

+1 −1
Original line number Diff line number Diff line
@@ -2803,7 +2803,7 @@ struct sk_buff *__skb_gso_segment(struct sk_buff *skb, 


	segs = skb_mac_gso_segment(skb, features);



	if (unlikely(skb_needs_check(skb, tx_path)))

	if (unlikely(skb_needs_check(skb, tx_path) && !IS_ERR(segs)))

		skb_warn_bad_offload(skb);



	return segs;