Commit 8d67d3c2 authored Mar 15, 2016 by Jun Piao Committed by Linus Torvalds Mar 15, 2016

ocfs2/dlm: fix a variable overflow problem in dlmdomain.c

In dlm_send_join_cancels(), node is defined with type unsigned int, but
initialized with -1, this will lead variable overflow.  Although this
won't cause any runtime problem, the code looks a little uncoordinated.

Signed-off-by: Jun Piao <piaojun@huawei.com>
Reviewed-by: Joseph Qi <joseph.qi@huawei.com>
Cc: Mark Fasheh <mfasheh@suse.de>
Cc: Joel Becker <jlbec@evilplan.org>
Cc: Junxiao Bi <junxiao.bi@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 814ce694

fs/ocfs2/dlm/dlmdomain.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1399,7 +1399,7 @@ static int dlm_send_join_cancels(struct dlm_ctxt *dlm,
		unsigned int map_size)
		{
		int status, tmpstat;
		unsigned int node;
		int node;

		if (map_size != (BITS_TO_LONGS(O2NM_MAX_NODES) *
		sizeof(unsigned long))) {