Commit 8d63a6d5 authored Jul 04, 2016 by Amitoj Kaur Chawla Committed by Herbert Xu Jul 05, 2016

crypto: bfin_crc - Simplify use of devm_ioremap_resource



Remove unneeded error handling on the result of a call to
platform_get_resource when the value is passed to
devm_ioremap_resource.

The Coccinelle semantic patch that makes this change is as follows:

// <smpl>
@@
expression pdev,res,n,e,e1;
expression ret != 0;
identifier l;
@@

- res = platform_get_resource(pdev, IORESOURCE_MEM, n);
  ... when != res
- if (res == NULL) { ... \(goto l;\|return ret;\) }
  ... when != res
+ res = platform_get_resource(pdev, IORESOURCE_MEM, n);
  e = devm_ioremap_resource(e1, res);
// </smpl>

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent 8c419778

drivers/crypto/bfin_crc.c

+0 −5

Original line number	Diff line number	Diff line
		@@ -588,11 +588,6 @@ static int bfin_crypto_crc_probe(struct platform_device *pdev)
		crypto_init_queue(&crc->queue, CRC_CCRYPTO_QUEUE_LENGTH);

		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
		if (res == NULL) {
		dev_err(&pdev->dev, "Cannot get IORESOURCE_MEM\n");
		return -ENOENT;
		}

		crc->regs = devm_ioremap_resource(dev, res);
		if (IS_ERR((void *)crc->regs)) {
		dev_err(&pdev->dev, "Cannot map CRC IO\n");