Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8d6185b5 authored by Daniel Vetter's avatar Daniel Vetter Committed by Russell King
Browse files

drm/armada: plug leak in dumb_map_offset 



We need to drop the gem bo reference if it's an imported one.

Signed-off-by: default avatarDaniel Vetter <daniel.vetter@intel.com>
Signed-off-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
parent 7a6f7133

drivers/gpu/drm/armada/armada_gem.c

+2 −1
Original line number Diff line number Diff line
@@ -285,7 +285,7 @@ int armada_gem_dumb_map_offset(struct drm_file *file, struct drm_device *dev, 
	/* Don't allow imported objects to be mapped */

	if (obj->obj.import_attach) {

		ret = -EINVAL;

		goto err_unlock;

		goto err_unref;

	}



	ret = drm_gem_create_mmap_offset(&obj->obj);
@@ -294,6 +294,7 @@ int armada_gem_dumb_map_offset(struct drm_file *file, struct drm_device *dev, 
		DRM_DEBUG_DRIVER("handle %#x offset %llx\n", handle, *offset);

	}



 err_unref:

	drm_gem_object_unreference(&obj->obj);

 err_unlock:

	mutex_unlock(&dev->struct_mutex);