Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8d44e9e6 authored by Maarten Lankhorst's avatar Maarten Lankhorst
Browse files

drm/framebuffer: Print task that allocated the fb in debug info. 



This is is very useful to finding sources of leaked framebufers.
The fbcon fb is annotated with [fbcon], to give it a better name
than kworker.

Signed-off-by: default avatarMaarten Lankhorst <maarten.lankhorst@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20171220093545.613-3-maarten.lankhorst@linux.intel.com


Reviewed-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
parent 48c9571c

drivers/gpu/drm/drm_fb_helper.c

+1 −0
Original line number Diff line number Diff line
@@ -1896,6 +1896,7 @@ static int drm_fb_helper_single_fb_probe(struct drm_fb_helper *fb_helper, 
	if (ret < 0)

		return ret;



	strcpy(fb_helper->fb->comm, "[fbcon]");

	return 0;

}

drivers/gpu/drm/drm_framebuffer.c

+2 −0
Original line number Diff line number Diff line
@@ -664,6 +664,7 @@ int drm_framebuffer_init(struct drm_device *dev, struct drm_framebuffer *fb, 
	INIT_LIST_HEAD(&fb->filp_head);



	fb->funcs = funcs;

	strcpy(fb->comm, current->comm);



	ret = __drm_mode_object_add(dev, &fb->base, DRM_MODE_OBJECT_FB,

				    false, drm_framebuffer_free);
@@ -978,6 +979,7 @@ void drm_framebuffer_print_info(struct drm_printer *p, unsigned int indent, 
	struct drm_format_name_buf format_name;

	unsigned int i;



	drm_printf_indent(p, indent, "allocated by = %s\n", fb->comm);

	drm_printf_indent(p, indent, "refcount=%u\n",

			  drm_framebuffer_read_refcount(fb));

	drm_printf_indent(p, indent, "format=%s\n",

include/drm/drm_framebuffer.h

+6 −0
Original line number Diff line number Diff line
@@ -121,6 +121,12 @@ struct drm_framebuffer { 
	 * @base: base modeset object structure, contains the reference count.

	 */

	struct drm_mode_object base;



	/**

	 * @comm: Name of the process allocating the fb, used for fb dumping.

	 */

	char comm[TASK_COMM_LEN];



	/**

	 * @format: framebuffer format information

	 */