Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8d3e6b55 authored by Alexandre Belloni's avatar Alexandre Belloni
Browse files

rtc: stk17ta8: fix possible race condition 



The probe function is not allowed to fail after registering the RTC. Call
rtc_register_device() at the end.

Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent 91cb6774

drivers/rtc/rtc-stk17ta8.c

+2 −2
Original line number Diff line number Diff line
@@ -334,11 +334,11 @@ static int stk17ta8_rtc_probe(struct platform_device *pdev) 


	pdata->rtc->ops = &stk17ta8_rtc_ops;



	ret = rtc_register_device(pdata->rtc);

	ret = sysfs_create_bin_file(&pdev->dev.kobj, &stk17ta8_nvram_attr);

	if (ret)

		return ret;



	ret = sysfs_create_bin_file(&pdev->dev.kobj, &stk17ta8_nvram_attr);

	ret = rtc_register_device(pdata->rtc);



	return ret;

}