Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8d1c3c07 authored by Tony Breeds's avatar Tony Breeds Committed by David S. Miller
Browse files

ixgbe: Be explict with what we are !'ing in ixgbe_sfp_config_module_task() 



GCC warns:
drivers/net/ixgbe/ixgbe_main.c: In function 'ixgbe_sfp_config_module_task':
drivers/net/ixgbe/ixgbe_main.c:3920: warning: suggest parantheses around
operand of '!' or change '&' to '&&' or '!' to '~'

Which I think is right.  Bracket to remove ambiguity.

Signed-off-by: default avatarTony Breeds <tony@bakeyournoodle.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 04193058

drivers/net/ixgbe/ixgbe_main.c

+1 −1
Original line number Diff line number Diff line
@@ -3917,7 +3917,7 @@ static void ixgbe_sfp_config_module_task(struct work_struct *work) 
	}

	hw->mac.ops.setup_sfp(hw);



	if (!adapter->flags & IXGBE_FLAG_IN_SFP_LINK_TASK)

	if (!(adapter->flags & IXGBE_FLAG_IN_SFP_LINK_TASK))

		/* This will also work for DA Twinax connections */

		schedule_work(&adapter->multispeed_fiber_task);

	adapter->flags &= ~IXGBE_FLAG_IN_SFP_MOD_TASK;