Commit 8ccc1131 authored May 10, 2018 by Christophe JAILLET Committed by David S. Miller May 11, 2018

mlxsw: core: Fix an error handling path in 'mlxsw_core_bus_device_register()'



Resources are not freed in the reverse order of the allocation.
Labels are also mixed-up.

Fix it and reorder code and labels in the error handling path of
'mlxsw_core_bus_device_register()'

Fixes: ef3116e5 ("mlxsw: spectrum: Register KVD resources with devlink")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 89dd2e75

drivers/net/ethernet/mellanox/mlxsw/core.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1100,11 +1100,11 @@ int mlxsw_core_bus_device_register(const struct mlxsw_bus_info *mlxsw_bus_info,
		err_alloc_lag_mapping:
		mlxsw_ports_fini(mlxsw_core);
		err_ports_init:
		mlxsw_bus->fini(bus_priv);
		err_bus_init:
		if (!reload)
		devlink_resources_unregister(devlink, NULL);
		err_register_resources:
		mlxsw_bus->fini(bus_priv);
		err_bus_init:
		if (!reload)
		devlink_free(devlink);
		err_devlink_alloc: