Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8c93c400 authored by Dan Carpenter's avatar Dan Carpenter Committed by Mauro Carvalho Chehab
Browse files

[media] go7007: dubious one-bit signed bitfields 



Because they're signed, "is_video" and "is_audio" can be 0 and -1
instead of 0 and 1 as intended.  It doesn't cause a bug, but it makes
Sparse complain:
drivers/staging/media/go7007/go7007-priv.h:94:31: error: dubious one-bit signed bitfield
drivers/staging/media/go7007/go7007-priv.h:95:31: error: dubious one-bit signed bitfield

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 5ddfbbb9

drivers/staging/media/go7007/go7007-priv.h

+2 −2
Original line number Diff line number Diff line
@@ -91,8 +91,8 @@ struct go7007_board_info { 
	int num_i2c_devs;

	struct go_i2c {

		const char *type;

		int is_video:1;

		int is_audio:1;

		unsigned int is_video:1;

		unsigned int is_audio:1;

		int addr;

		u32 flags;

	} i2c_devs[5];