Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8c873e21 authored by Florian Westphal's avatar Florian Westphal Committed by Pablo Neira Ayuso
Browse files

netfilter: core: free hooks with call_rcu 



Giuseppe Scrivano says:
  "SELinux, if enabled, registers for each new network namespace 6
    netfilter hooks."

Cost for this is high.  With synchronize_net() removed:
   "The net benefit on an SMP machine with two cores is that creating a
   new network namespace takes -40% of the original time."

This patch replaces synchronize_net+kvfree with call_rcu().
We store rcu_head at the tail of a structure that has no fixed layout,
i.e. we cannot use offsetof() to compute the start of the original
allocation.  Thus store this information right after the rcu head.

We could simplify this by just placing the rcu_head at the start
of struct nf_hook_entries.  However, this structure is used in
packet processing hotpath, so only place what is needed for that
at the beginning of the struct.

Reported-by: default avatarGiuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: default avatarFlorian Westphal <fw@strlen.de>
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
parent 26888dfd

include/linux/netfilter.h

+15 −4
Original line number Diff line number Diff line
@@ -77,17 +77,28 @@ struct nf_hook_entry { 
	void				*priv;

};



struct nf_hook_entries_rcu_head {

	struct rcu_head head;

	void	*allocation;

};



struct nf_hook_entries {

	u16				num_hook_entries;

	/* padding */

	struct nf_hook_entry		hooks[];



	/* trailer: pointers to original orig_ops of each hook.

	/* trailer: pointers to original orig_ops of each hook,

	 * followed by rcu_head and scratch space used for freeing

	 * the structure via call_rcu.

	 *

	 *   This is not part of struct nf_hook_entry since its only

	 * needed in slow path (hook register/unregister).

	 *

	 *   needed in slow path (hook register/unregister):

	 * const struct nf_hook_ops     *orig_ops[]

	 *

	 *   For the same reason, we store this at end -- its

	 *   only needed when a hook is deleted, not during

	 *   packet path processing:

	 * struct nf_hook_entries_rcu_head     head

	 */

};

net/netfilter/core.c

+28 −6
Original line number Diff line number Diff line
@@ -74,7 +74,8 @@ static struct nf_hook_entries *allocate_hook_entries_size(u16 num) 
	struct nf_hook_entries *e;

	size_t alloc = sizeof(*e) +

		       sizeof(struct nf_hook_entry) * num +

		       sizeof(struct nf_hook_ops *) * num;

		       sizeof(struct nf_hook_ops *) * num +

		       sizeof(struct nf_hook_entries_rcu_head);



	if (num == 0)

		return NULL;
@@ -85,6 +86,30 @@ static struct nf_hook_entries *allocate_hook_entries_size(u16 num) 
	return e;

}



static void __nf_hook_entries_free(struct rcu_head *h)

{

	struct nf_hook_entries_rcu_head *head;



	head = container_of(h, struct nf_hook_entries_rcu_head, head);

	kvfree(head->allocation);

}



static void nf_hook_entries_free(struct nf_hook_entries *e)

{

	struct nf_hook_entries_rcu_head *head;

	struct nf_hook_ops **ops;

	unsigned int num;



	if (!e)

		return;



	num = e->num_hook_entries;

	ops = nf_hook_entries_get_hook_ops(e);

	head = (void *)&ops[num];

	head->allocation = e;

	call_rcu(&head->head, __nf_hook_entries_free);

}



static unsigned int accept_all(void *priv,

			       struct sk_buff *skb,

			       const struct nf_hook_state *state)
@@ -291,9 +316,8 @@ int nf_register_net_hook(struct net *net, const struct nf_hook_ops *reg) 
#ifdef HAVE_JUMP_LABEL

	static_key_slow_inc(&nf_hooks_needed[reg->pf][reg->hooknum]);

#endif

	synchronize_net();

	BUG_ON(p == new_hooks);

	kvfree(p);

	nf_hook_entries_free(p);

	return 0;

}

EXPORT_SYMBOL(nf_register_net_hook);
@@ -361,10 +385,8 @@ void nf_unregister_net_hook(struct net *net, const struct nf_hook_ops *reg) 
	if (!p)

		return;



	synchronize_net();



	nf_queue_nf_hook_drop(net);

	kvfree(p);

	nf_hook_entries_free(p);

}

EXPORT_SYMBOL(nf_unregister_net_hook);