Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8c1f4546 authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller
Browse files

netxen: netxen_rom_fast_read() doesn't return -1 



The error handling is broken here.  netxen_rom_fast_read() returns zero
on success and -EIO on error.  It never returns -1.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 1c755ffa

drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c

+2 −1
Original line number Diff line number Diff line
@@ -852,7 +852,8 @@ netxen_check_options(struct netxen_adapter *adapter) 
	ptr32 = (__le32 *)&serial_num;

	offset = NX_FW_SERIAL_NUM_OFFSET;

	for (i = 0; i < 8; i++) {

		if (netxen_rom_fast_read(adapter, offset, &val) == -1) {

		err = netxen_rom_fast_read(adapter, offset, &val);

		if (err) {

			dev_err(&pdev->dev, "error reading board info\n");

			adapter->driver_mismatch = 1;

			return;