Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8ba6b30e authored by Petr Machata's avatar Petr Machata Committed by David S. Miller
Browse files

mlxsw: spectrum_router: Remove batch neighbour deletion causing FW bug 



This reverts commit 63dd00fa.

RAUHT DELETE_ALL seems to trigger a bug in FW. That manifests by later
calls to RAUHT ADD of an IPv6 neighbor to fail with "bad parameter"
error code.

Signed-off-by: default avatarPetr Machata <petrm@mellanox.com>
Fixes: 63dd00fa ("mlxsw: spectrum_router: Add batch neighbour deletion")
Reviewed-by: default avatarIdo Schimmel <idosch@mellanox.com>
Signed-off-by: default avatarJiri Pirko <jiri@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 748a240c

drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c

+3 −12
Original line number Diff line number Diff line
@@ -2436,26 +2436,17 @@ static void mlxsw_sp_neigh_fini(struct mlxsw_sp *mlxsw_sp) 
	rhashtable_destroy(&mlxsw_sp->router->neigh_ht);

}



static int mlxsw_sp_neigh_rif_flush(struct mlxsw_sp *mlxsw_sp,

				    const struct mlxsw_sp_rif *rif)

{

	char rauht_pl[MLXSW_REG_RAUHT_LEN];



	mlxsw_reg_rauht_pack(rauht_pl, MLXSW_REG_RAUHT_OP_WRITE_DELETE_ALL,

			     rif->rif_index, rif->addr);

	return mlxsw_reg_write(mlxsw_sp->core, MLXSW_REG(rauht), rauht_pl);

}



static void mlxsw_sp_neigh_rif_gone_sync(struct mlxsw_sp *mlxsw_sp,

					 struct mlxsw_sp_rif *rif)

{

	struct mlxsw_sp_neigh_entry *neigh_entry, *tmp;



	mlxsw_sp_neigh_rif_flush(mlxsw_sp, rif);

	list_for_each_entry_safe(neigh_entry, tmp, &rif->neigh_list,

				 rif_list_node)

				 rif_list_node) {

		mlxsw_sp_neigh_entry_update(mlxsw_sp, neigh_entry, false);

		mlxsw_sp_neigh_entry_destroy(mlxsw_sp, neigh_entry);

	}

}



enum mlxsw_sp_nexthop_type {

	MLXSW_SP_NEXTHOP_TYPE_ETH,