Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8b8f0813 authored by Taehee Yoo's avatar Taehee Yoo Committed by Pablo Neira Ayuso
Browse files

netfilter: nf_nat_snmp_basic: replace ctinfo with dir. 



The snmp_translate() receives ctinfo data to get dir value only.
because of caller already has dir value, we just replace ctinfo with dir.

Signed-off-by: default avatarTaehee Yoo <ap420073@gmail.com>
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
parent e29e5ddc

net/ipv4/netfilter/nf_nat_snmp_basic.c

+2 −5
Original line number Diff line number Diff line
@@ -1082,15 +1082,12 @@ static int snmp_parse_mangle(unsigned char *msg, 
/*

 * SNMP translation routine.

 */

static int snmp_translate(struct nf_conn *ct,

			  enum ip_conntrack_info ctinfo,

			  struct sk_buff *skb)

static int snmp_translate(struct nf_conn *ct, int dir, struct sk_buff *skb)

{

	struct iphdr *iph = ip_hdr(skb);

	struct udphdr *udph = (struct udphdr *)((__be32 *)iph + iph->ihl);

	u_int16_t udplen = ntohs(udph->len);

	u_int16_t paylen = udplen - sizeof(struct udphdr);

	int dir = CTINFO2DIR(ctinfo);

	struct oct1_map map;



	/*
@@ -1155,7 +1152,7 @@ static int help(struct sk_buff *skb, unsigned int protoff, 
		return NF_DROP;



	spin_lock_bh(&snmp_lock);

	ret = snmp_translate(ct, ctinfo, skb);

	ret = snmp_translate(ct, dir, skb);

	spin_unlock_bh(&snmp_lock);

	return ret;

}