Commit 8aeabc37 authored Sep 23, 2005 by Pavel Roskin Committed by Jeff Garzik Sep 23, 2005

[PATCH] orinoco: orinoco_send_wevents() could return without unlocking.



Signed-off-by: Pavel Roskin <proski@gnu.org>

orinoco_send_wevents() could return without unlocking.

Failure to read BSSID from the hardware would cause orinoco_send_wevents() to
return with lock held.  Found by sparse.
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>

parent f3cb4cc1

drivers/net/wireless/orinoco.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -1112,12 +1112,14 @@ static void orinoco_send_wevents(struct net_device *dev)
		err = hermes_read_ltv(hw, IRQ_BAP, HERMES_RID_CURRENTBSSID,
		ETH_ALEN, NULL, wrqu.ap_addr.sa_data);
		if (err != 0)
		return;
		goto out;

		wrqu.ap_addr.sa_family = ARPHRD_ETHER;

		/* Send event to user space */
		wireless_send_event(dev, SIOCGIWAP, &wrqu, NULL);

		out:
		orinoco_unlock(priv, &flags);
		}