Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8ac9e914 authored by Pan Bian's avatar Pan Bian Committed by Mauro Carvalho Chehab
Browse files

media: mtk-mdp: use IS_ERR to check return value of of_clk_get 



Function of_clk_get() returns an ERR_PTR on failures. In file
mtk_mdp_commp.c, its return value is checked against NULL. Such checks
cannot prevent from accessing bad memory. This patch replaces the NULL
checks with IS_ERR checks.

Signed-off-by: default avatarPan Bian <bianpan2016@163.com>
Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent 68d9c47b

drivers/media/platform/mtk-mdp/mtk_mdp_comp.c

+2 −2
Original line number Diff line number Diff line
@@ -75,7 +75,7 @@ void mtk_mdp_comp_clock_on(struct device *dev, struct mtk_mdp_comp *comp) 
	}



	for (i = 0; i < ARRAY_SIZE(comp->clk); i++) {

		if (!comp->clk[i])

		if (IS_ERR(comp->clk[i]))

			continue;

		err = clk_prepare_enable(comp->clk[i]);

		if (err)
@@ -90,7 +90,7 @@ void mtk_mdp_comp_clock_off(struct device *dev, struct mtk_mdp_comp *comp) 
	int i;



	for (i = 0; i < ARRAY_SIZE(comp->clk); i++) {

		if (!comp->clk[i])

		if (IS_ERR(comp->clk[i]))

			continue;

		clk_disable_unprepare(comp->clk[i]);

	}