Commit 8a8c74bf authored Oct 26, 2007 by Chuck Lever Committed by Trond Myklebust Jan 30, 2008

NFS: Ensure nfs_wcc_update_inode always converts file size to loff_t



The nfs_wcc_update_inode() function omits logic to convert the type of
the NFS on-the-wire value of a file's size (__u64) to the type of file
size value stored in struct inode (loff_t, which is signed).

Everywhere else in the NFS client I checked already correctly converts the
file size type.

This effects only very large files.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

parent 9b45b74c

fs/nfs/inode.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -814,8 +814,9 @@ static void nfs_wcc_update_inode(struct inode inode, struct nfs_fattr fattr)
		if (S_ISDIR(inode->i_mode))
		nfsi->cache_validity \|= NFS_INO_INVALID_DATA;
		}
		if (inode->i_size == fattr->pre_size && nfsi->npages == 0)
		inode->i_size = fattr->size;
		if (inode->i_size == nfs_size_to_loff_t(fattr->pre_size) &&
		nfsi->npages == 0)
		inode->i_size = nfs_size_to_loff_t(fattr->size);
		}
		}