Commit 89eaaf2d authored May 04, 2018 by Mauro Carvalho Chehab

media: lgdt330x: don't use an uninitialized state

If state is not initialized or is freed, we can't use it:
drivers/media/dvb-frontends/lgdt330x.c:920 lgdt330x_probe() error: potential null dereference 'state'. (kzalloc returns null)
drivers/media/dvb-frontends/lgdt330x.c:920 lgdt330x_probe() error: we previously assumed 'state' could be null (see line 878)
drivers/media/dvb-frontends/lgdt330x.c:920 lgdt330x_probe() error: dereferencing freed memory 'state'

Fixes: 23ba635d ("media: lgdt330x: convert it to the new I2C binding way")
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>

parent 5f939c36

drivers/media/dvb-frontends/lgdt330x.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -917,7 +917,8 @@ static int lgdt330x_probe(struct i2c_client *client,

		error:
		kfree(state);
		dprintk(state, "ERROR\n");
		if (debug)
		dev_printk(KERN_DEBUG, &client->dev, "Error loading lgdt330x driver\n");
		return -ENODEV;
		}
		struct dvb_frontend lgdt330x_attach(const struct lgdt330x_config _config,