Commit 89e9facd authored Dec 23, 2019 by Corey Minyard Committed by Greg Kroah-Hartman Mar 05, 2020

ipmi:ssif: Handle a possible NULL pointer reference



[ Upstream commit 6b8526d3abc02c08a2f888e8c20b7ac9e5776dfe ]

In error cases a NULL can be passed to memcpy.  The length will always
be zero, so it doesn't really matter, but go ahead and check for NULL,
anyway, to be more precise and avoid static analysis errors.

Reported-by: kbuild test robot <lkp@intel.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 1d878018

drivers/char/ipmi/ipmi_ssif.c

+7 −3

Original line number	Diff line number	Diff line
		@@ -735,10 +735,14 @@ static void msg_done_handler(struct ssif_info *ssif_info, int result,
		flags = ipmi_ssif_lock_cond(ssif_info, &oflags);
		msg = ssif_info->curr_msg;
		if (msg) {
		if (data) {
		if (len > IPMI_MAX_MSG_LENGTH)
		len = IPMI_MAX_MSG_LENGTH;
		memcpy(msg->rsp, data, len);
		} else {
		len = 0;
		}
		msg->rsp_size = len;
		if (msg->rsp_size > IPMI_MAX_MSG_LENGTH)
		msg->rsp_size = IPMI_MAX_MSG_LENGTH;
		memcpy(msg->rsp, data, msg->rsp_size);
		ssif_info->curr_msg = NULL;
		}