Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 89bb35e2 authored by Kristina Martšenko's avatar Kristina Martšenko Committed by Jonathan Cameron
Browse files

iio: mxs-lradc: only update the buffer when its conversions have finished 



Using the touchscreen while running buffered capture results in the
buffer reporting lots of wrong values, often just zeros. This is because
we push readings to the buffer every time a touchscreen interrupt
arrives, including when the buffer's own conversions have not yet
finished. So let's only push to the buffer when its conversions are
ready.

Signed-off-by: default avatarKristina Martšenko <kristina.martsenko@gmail.com>
Reviewed-by: default avatarMarek Vasut <marex@denx.de>
Cc: Stable@vger.kernel.org
Signed-off-by: default avatarJonathan Cameron <jic23@kernel.org>
parent 6abe0300

drivers/staging/iio/adc/mxs-lradc.c

+5 −3
Original line number Diff line number Diff line
@@ -1152,10 +1152,12 @@ static irqreturn_t mxs_lradc_handle_irq(int irq, void *data) 
				LRADC_CTRL1_LRADC_IRQ(TOUCHSCREEN_VCHANNEL2));

	}



	if (iio_buffer_enabled(iio))

	if (iio_buffer_enabled(iio)) {

		if (reg & lradc->buffer_vchans)

			iio_trigger_poll(iio->trig);

	else if (reg & LRADC_CTRL1_LRADC_IRQ(0))

	} else if (reg & LRADC_CTRL1_LRADC_IRQ(0)) {

		complete(&lradc->completion);

	}



	mxs_lradc_reg_clear(lradc, reg & clr_irq, LRADC_CTRL1);