Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 89659bfd authored by Chao Yu's avatar Chao Yu Committed by Greg Kroah-Hartman
Browse files

f2fs: fix to unlock page correctly in error path of is_alive() 

commit 6d18762ed5cd549fde74fd0e05d4d87bac5a3beb upstream.

As Pavel Machek reported in below link [1]:

After commit 77900c45ee5c ("f2fs: fix to do sanity check in is_alive()"),
node page should be unlock via calling f2fs_put_page() in the error path
of is_alive(), otherwise, f2fs may hang when it tries to lock the node
page, fix it.

[1] https://lore.kernel.org/stable/20220124203637.GA19321@duo.ucw.cz/



Fixes: 77900c45ee5c ("f2fs: fix to do sanity check in is_alive()")
Cc: <stable@vger.kernel.org>
Reported-by: default avatarPavel Machek <pavel@denx.de>
Signed-off-by: default avatarPavel Machek <pavel@denx.de>
Signed-off-by: default avatarChao Yu <chao@kernel.org>
Signed-off-by: default avatarJaegeuk Kim <jaegeuk@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3a2789e8

fs/f2fs/gc.c

+3 −1
Original line number Diff line number Diff line
@@ -589,8 +589,10 @@ static bool is_alive(struct f2fs_sb_info *sbi, struct f2fs_summary *sum, 
		set_sbi_flag(sbi, SBI_NEED_FSCK);

	}



	if (f2fs_check_nid_range(sbi, dni->ino))

	if (f2fs_check_nid_range(sbi, dni->ino)) {

		f2fs_put_page(node_page, 1);

		return false;

	}



	*nofs = ofs_of_node(node_page);

	source_blkaddr = datablock_addr(NULL, node_page, ofs_in_node);