Commit 886e71de authored Oct 02, 2009 by Reinette Chatre Committed by John W. Linville Oct 07, 2009

iwlagn: fix compile warning in iwl5000_gain_computation



The return type of abs() was recently changed from int to long. With
min()'s type checking we thus need to make sure that values of the same
type are compared.

This fixes:

    CC [M]  drivers/net/wireless/iwlwifi/iwl-5000.o
drivers/net/wireless/iwlwifi/iwl-5000.c: In function ‘iwl5000_gain_computation’:
drivers/net/wireless/iwlwifi/iwl-5000.c:320: warning: comparison of distinct pointer types lacks a cast

Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
Reported-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

parent 9024adf5

drivers/net/wireless/iwlwifi/iwl-5000.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -317,7 +317,7 @@ static void iwl5000_gain_computation(struct iwl_priv *priv,
		(s32)average_noise[i])) / 1500;
		/* bound gain by 2 bits value max, 3rd bit is sign */
		data->delta_gain_code[i] =
		min(abs(delta_g), CHAIN_NOISE_MAX_DELTA_GAIN_CODE);
		min(abs(delta_g), (long) CHAIN_NOISE_MAX_DELTA_GAIN_CODE);

		if (delta_g < 0)
		/* set negative sign */