Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 885b0d43 authored by Petr Machata's avatar Petr Machata Committed by David S. Miller
Browse files

mlxsw: spectrum_span: Fix initialization of struct mlxsw_sp_span_parms 



Since the first element of struct mlxsw_sp_span_parms is a pointer,
to zero-initialize this structure the correct notation is not = {0}, but
rather = {NULL}, as reported by sparse.

Signed-off-by: default avatarPetr Machata <petrm@mellanox.com>
Acked-by: default avatarJiri Pirko <jiri@mellanox.com>
Signed-off-by: default avatarIdo Schimmel <idosch@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 440ea4ae

drivers/net/ethernet/mellanox/mlxsw/spectrum_span.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -730,7 +730,7 @@ int mlxsw_sp_span_mirror_add(struct mlxsw_sp_port *from, 
{

{

	struct mlxsw_sp *mlxsw_sp = from->mlxsw_sp;

	struct mlxsw_sp *mlxsw_sp = from->mlxsw_sp;

	const struct mlxsw_sp_span_entry_ops *ops;

	const struct mlxsw_sp_span_entry_ops *ops;

	struct mlxsw_sp_span_parms sparms = {0};

	struct mlxsw_sp_span_parms sparms = {NULL};

	struct mlxsw_sp_span_entry *span_entry;

	struct mlxsw_sp_span_entry *span_entry;

	int err;

	int err;
@@ -787,7 +787,7 @@ void mlxsw_sp_span_respin(struct mlxsw_sp *mlxsw_sp) 
	ASSERT_RTNL();

	ASSERT_RTNL();

	for (i = 0; i < mlxsw_sp->span.entries_count; i++) {

	for (i = 0; i < mlxsw_sp->span.entries_count; i++) {

		struct mlxsw_sp_span_entry *curr = &mlxsw_sp->span.entries[i];

		struct mlxsw_sp_span_entry *curr = &mlxsw_sp->span.entries[i];

		struct mlxsw_sp_span_parms sparms = {0};

		struct mlxsw_sp_span_parms sparms = {NULL};





		if (!curr->ref_count)

		if (!curr->ref_count)

			continue;

			continue;