Commit 8764a826 authored Dec 25, 2017 by Ido Schimmel Committed by David S. Miller Jan 02, 2018

mlxsw: spectrum_router: Fix NULL pointer deref



When we remove the neighbour associated with a nexthop we should always
refuse to write the nexthop to the adjacency table. Regardless if it is
already present in the table or not.

Otherwise, we risk dereferencing the NULL pointer that was set instead
of the neighbour.

Fixes: a7ff87ac ("mlxsw: spectrum_router: Implement next-hop routing")
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Reported-by: Alexander Petrovskiy <alexpe@mellanox.com>
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 2fa771be

drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -3228,7 +3228,7 @@ static void __mlxsw_sp_nexthop_neigh_update(struct mlxsw_sp_nexthop *nh,
		{
		if (!removing)
		nh->should_offload = 1;
		else if (nh->offloaded)
		else
		nh->should_offload = 0;
		nh->update = 1;
		}