Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 86aa7c1e authored by Pandiyarajan Pitchaimuthu's avatar Pandiyarajan Pitchaimuthu Committed by Kalle Valo
Browse files

ath6kl: Array index out of bounds check 



The variable assigned_ep can be assigned value of -1 and is never
checked if it equals -1. So the endpoint array can have -1  as the index
value and can be out of bounds.

The value of assigned_ep is checked for -1 and is ensured that the
endpoint array doesn't go out of bounds.

Signed-off-by: default avatarPandiyarajan Pitchaimuthu <c_ppitch@qca.qualcomm.com>
Signed-off-by: default avatarKalle Valo <kvalo@qca.qualcomm.com>
parent 698bf867

drivers/net/wireless/ath/ath6kl/htc_mbox.c

+2 −1
Original line number Original line Diff line number Diff line
@@ -2492,7 +2492,8 @@ static int ath6kl_htc_mbox_conn_service(struct htc_target *target, 
		max_msg_sz = le16_to_cpu(resp_msg->max_msg_sz);

		max_msg_sz = le16_to_cpu(resp_msg->max_msg_sz);

	}

	}





	if (assigned_ep >= ENDPOINT_MAX || !max_msg_sz) {

	if (WARN_ON_ONCE(assigned_ep == ENDPOINT_UNUSED ||

			 assigned_ep >= ENDPOINT_MAX || !max_msg_sz)) {

		status = -ENOMEM;

		status = -ENOMEM;

		goto fail_tx;

		goto fail_tx;

	}

	}