Commit 86a33ae1 authored Nov 30, 2016 by Roi Dayan Committed by David S. Miller Dec 02, 2016

net/mlx5e: Correct cleanup order when deleting offloaded TC rules



According to the reverse unwinding principle, on delete time we should
first handle deletion of the steering rule and later handle the vlan
deletion from the eswitch.

Fixes: 8b32580d ("net/mlx5e: Add TC vlan action for SRIOV offloads")
Signed-off-by: Roi Dayan <roid@mellanox.com>
Reviewed-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 53636068

drivers/net/ethernet/mellanox/mlx5/core/en_tc.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -151,11 +151,11 @@ static void mlx5e_tc_del_flow(struct mlx5e_priv *priv,

		counter = mlx5_flow_rule_counter(rule);

		mlx5_del_flow_rules(rule);

		if (esw && esw->mode == SRIOV_OFFLOADS)
		mlx5_eswitch_del_vlan_action(esw, attr);

		mlx5_del_flow_rules(rule);

		mlx5_fc_destroy(priv->mdev, counter);

		if (!mlx5e_tc_num_filters(priv) && (priv->fs.tc.t)) {