Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8652bcbf authored by Andreas Larsson's avatar Andreas Larsson Committed by Felipe Balbi
Browse files

usb: gadget: gr_udc: Use GFP_ATOMIC when allocating under held spinlock 



As gr_ep_init must be called with dev->lock held, GFP_KERNEL must not be used.

Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>

Signed-off-by: default avatarAndreas Larsson <andreas@gaisler.com>
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
parent b38d27e5

drivers/usb/gadget/gr_udc.c

+2 −2
Original line number Diff line number Diff line
@@ -1990,8 +1990,8 @@ static int gr_ep_init(struct gr_udc *dev, int num, int is_in, u32 maxplimit) 
	INIT_LIST_HEAD(&ep->queue);



	if (num == 0) {

		_req = gr_alloc_request(&ep->ep, GFP_KERNEL);

		buf = devm_kzalloc(dev->dev, PAGE_SIZE, GFP_DMA | GFP_KERNEL);

		_req = gr_alloc_request(&ep->ep, GFP_ATOMIC);

		buf = devm_kzalloc(dev->dev, PAGE_SIZE, GFP_DMA | GFP_ATOMIC);

		if (!_req || !buf) {

			/* possible _req freed by gr_probe via gr_remove */

			return -ENOMEM;