Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8565f052 authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: hda - Fix wrong dirty check in snd_hda_codec_resume_amp() 



The dirty entry has to be checked at the beginning in the loop, not in
the inner loop for channels.  This caused a regression that the right
channel isn't properly written.

Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 3bbcd274

sound/pci/hda/hda_codec.c

+3 −3
Original line number Diff line number Diff line
@@ -1969,6 +1969,9 @@ void snd_hda_codec_resume_amp(struct hda_codec *codec) 
		unsigned int idx, dir, ch;



		buffer = snd_array_elem(&codec->amp_cache.buf, i);

		if (!buffer->head.dirty)

			continue;

		buffer->head.dirty = 0;

		key = buffer->head.key;

		if (!key)

			continue;
@@ -1978,9 +1981,6 @@ void snd_hda_codec_resume_amp(struct hda_codec *codec) 
		for (ch = 0; ch < 2; ch++) {

			if (!(buffer->head.val & INFO_AMP_VOL(ch)))

				continue;

			if (!buffer->head.dirty)

				continue;

			buffer->head.dirty = 0;

			mutex_unlock(&codec->hash_mutex);

			put_vol_mute(codec, buffer, nid, ch, dir, idx,

				     buffer->vol[ch]);