Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8544d0e3 authored by Kim, Milo's avatar Kim, Milo Committed by Linus Torvalds
Browse files

leds-lm3530: remove LM3530_ALS_ZONE_REG code 



LM3530_ALS_ZONE_REG is read-only register.
Writing this register is not necessary.

Signed-off-by: default avatarMilo(Woogyom) Kim <milo.kim@ti.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Richard Purdie <rpurdie@rpsys.net>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent bb982009

drivers/leds/leds-lm3530.c

+12 −15
Original line number Diff line number Diff line
@@ -26,7 +26,6 @@ 
#define LM3530_GEN_CONFIG		0x10

#define LM3530_ALS_CONFIG		0x20

#define LM3530_BRT_RAMP_RATE		0x30

#define LM3530_ALS_ZONE_REG		0x40

#define LM3530_ALS_IMP_SELECT		0x41

#define LM3530_BRT_CTRL_REG		0xA0

#define LM3530_ALS_ZB0_REG		0x60
@@ -38,7 +37,7 @@ 
#define LM3530_ALS_Z2T_REG		0x72

#define LM3530_ALS_Z3T_REG		0x73

#define LM3530_ALS_Z4T_REG		0x74

#define LM3530_REG_MAX			15

#define LM3530_REG_MAX			14



/* General Control Register */

#define LM3530_EN_I2C_SHIFT		(0)
@@ -118,7 +117,6 @@ static const u8 lm3530_reg[LM3530_REG_MAX] = { 
	LM3530_GEN_CONFIG,

	LM3530_ALS_CONFIG,

	LM3530_BRT_RAMP_RATE,

	LM3530_ALS_ZONE_REG,

	LM3530_ALS_IMP_SELECT,

	LM3530_BRT_CTRL_REG,

	LM3530_ALS_ZB0_REG,
@@ -217,18 +215,17 @@ static int lm3530_init_registers(struct lm3530_data *drvdata) 
	reg_val[0] = gen_config;	/* LM3530_GEN_CONFIG */

	reg_val[1] = als_config;	/* LM3530_ALS_CONFIG */

	reg_val[2] = brt_ramp;		/* LM3530_BRT_RAMP_RATE */

	reg_val[3] = 0x00;		/* LM3530_ALS_ZONE_REG */

	reg_val[4] = als_imp_sel;	/* LM3530_ALS_IMP_SELECT */

	reg_val[5] = brightness;	/* LM3530_BRT_CTRL_REG */

	reg_val[6] = zones[0];		/* LM3530_ALS_ZB0_REG */

	reg_val[7] = zones[1];		/* LM3530_ALS_ZB1_REG */

	reg_val[8] = zones[2];		/* LM3530_ALS_ZB2_REG */

	reg_val[9] = zones[3];		/* LM3530_ALS_ZB3_REG */

	reg_val[10] = LM3530_DEF_ZT_0;	/* LM3530_ALS_Z0T_REG */

	reg_val[11] = LM3530_DEF_ZT_1;	/* LM3530_ALS_Z1T_REG */

	reg_val[12] = LM3530_DEF_ZT_2;	/* LM3530_ALS_Z2T_REG */

	reg_val[13] = LM3530_DEF_ZT_3;	/* LM3530_ALS_Z3T_REG */

	reg_val[14] = LM3530_DEF_ZT_4;	/* LM3530_ALS_Z4T_REG */

	reg_val[3] = als_imp_sel;	/* LM3530_ALS_IMP_SELECT */

	reg_val[4] = brightness;	/* LM3530_BRT_CTRL_REG */

	reg_val[5] = zones[0];		/* LM3530_ALS_ZB0_REG */

	reg_val[6] = zones[1];		/* LM3530_ALS_ZB1_REG */

	reg_val[7] = zones[2];		/* LM3530_ALS_ZB2_REG */

	reg_val[8] = zones[3];		/* LM3530_ALS_ZB3_REG */

	reg_val[9] = LM3530_DEF_ZT_0;	/* LM3530_ALS_Z0T_REG */

	reg_val[10] = LM3530_DEF_ZT_1;	/* LM3530_ALS_Z1T_REG */

	reg_val[11] = LM3530_DEF_ZT_2;	/* LM3530_ALS_Z2T_REG */

	reg_val[12] = LM3530_DEF_ZT_3;	/* LM3530_ALS_Z3T_REG */

	reg_val[13] = LM3530_DEF_ZT_4;	/* LM3530_ALS_Z4T_REG */



	if (!drvdata->enable) {

		ret = regulator_enable(drvdata->regulator);