Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8521b4e6 authored by Sergio Paracuellos's avatar Sergio Paracuellos Committed by Greg Kroah-Hartman
Browse files

staging: ks7010: refactor ks_wlan_set_preamble function 



Change if logic to handle invalid values first and just
assign at the end the valid one if it is the case.

Signed-off-by: default avatarSergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c8712580

drivers/staging/ks7010/ks_wlan_net.c

+2 −6
Original line number Diff line number Diff line
@@ -1860,14 +1860,10 @@ static int ks_wlan_set_preamble(struct net_device *dev, 
		return -EPERM;



	/* for SLEEP MODE */

	if (*uwrq == LONG_PREAMBLE) {	/* 0 */

		priv->reg.preamble = LONG_PREAMBLE;

	} else if (*uwrq == SHORT_PREAMBLE) {	/* 1 */

		priv->reg.preamble = SHORT_PREAMBLE;

	} else {

	if (*uwrq != LONG_PREAMBLE && *uwrq != SHORT_PREAMBLE)

		return -EINVAL;

	}



	priv->reg.preamble = *uwrq;

	priv->need_commit |= SME_MODE_SET;

	return -EINPROGRESS;	/* Call commit handler */

}