Commit 842e528e authored Nov 14, 2014 by Dmitry Torokhov Committed by Linus Walleij Nov 27, 2014

gpio: tz1090: Fix error handling of irq_of_parse_and_map



irq_of_parse_and_map() returns 0 on error, so testing for negative
result never works.

Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
Acked-by: James Hogan <james.hogan@imgtec.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent d0c3d95a

drivers/gpio/gpio-tz1090.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -446,7 +446,7 @@ static int tz1090_gpio_bank_probe(struct tz1090_gpio_bank_info *info)
		bank->irq = irq_of_parse_and_map(np, 0);

		/* The interrupt is optional (it may be used by another core on chip) */
		if (bank->irq < 0) {
		if (!bank->irq) {
		dev_info(dev, "IRQ not provided for bank %u, IRQs disabled\n",
		info->index);
		return 0;