Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 841f4f24 authored Oct 13, 2017 by Vivien Didelot Committed by David S. Miller Oct 14, 2017

net: dsa: remove .set_addr



Now that there is no user for the .set_addr function, remove it from
DSA. If a switch supports this feature (like mv88e6xxx), the
implementation can be done in the driver setup.

Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 93004a93

include/net/dsa.h

+0 −1

Original line number	Diff line number	Diff line
		@@ -291,7 +291,6 @@ struct dsa_switch_ops {
		enum dsa_tag_protocol (get_tag_protocol)(struct dsa_switch ds);

		int (setup)(struct dsa_switch ds);
		int (set_addr)(struct dsa_switch ds, u8 *addr);
		u32 (get_phy_flags)(struct dsa_switch ds, int port);

		/*

net/dsa/dsa2.c

+0 −6

Original line number	Diff line number	Diff line
		@@ -336,12 +336,6 @@ static int dsa_ds_apply(struct dsa_switch_tree dst, struct dsa_switch ds)
		if (err)
		return err;

		if (ds->ops->set_addr) {
		err = ds->ops->set_addr(ds, dst->cpu_dp->netdev->dev_addr);
		if (err < 0)
		return err;
		}

		if (!ds->slave_mii_bus && ds->ops->phy_read) {
		ds->slave_mii_bus = devm_mdiobus_alloc(ds->dev);
		if (!ds->slave_mii_bus)

net/dsa/legacy.c

+0 −6

Original line number	Diff line number	Diff line
		@@ -172,12 +172,6 @@ static int dsa_switch_setup_one(struct dsa_switch *ds,
		if (ret)
		return ret;

		if (ops->set_addr) {
		ret = ops->set_addr(ds, master->dev_addr);
		if (ret < 0)
		return ret;
		}

		if (!ds->slave_mii_bus && ops->phy_read) {
		ds->slave_mii_bus = devm_mdiobus_alloc(ds->dev);
		if (!ds->slave_mii_bus)