Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 83c8bcce authored by Frank Schaefer's avatar Frank Schaefer Committed by Mauro Carvalho Chehab
Browse files

[media] em28xx: disable ioctl VIDIOC_S_PARM for VBI devices 



VIDIOC_S_PARM doesn't make sense for VBI device nodes, because we don't support
selecting the number of read buffers to use.

Signed-off-by: default avatarFrank Schäfer <fschaefer.oss@googlemail.com>
Acked-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 3bc85cce

drivers/media/usb/em28xx/em28xx-video.c

+1 −0
Original line number Diff line number Diff line
@@ -1920,6 +1920,7 @@ int em28xx_register_analog_devices(struct em28xx *dev) 
		dev->vbi_dev->queue->lock = &dev->vb_vbi_queue_lock;



		/* disable inapplicable ioctls */

		v4l2_disable_ioctl(dev->vdev, VIDIOC_S_PARM);

		if (dev->tuner_type == TUNER_ABSENT) {

			v4l2_disable_ioctl(dev->vbi_dev, VIDIOC_G_TUNER);

			v4l2_disable_ioctl(dev->vbi_dev, VIDIOC_S_TUNER);