Commit 839c4227 authored Apr 06, 2018 by Christophe JAILLET Committed by Dmitry Torokhov Apr 06, 2018

Input: synaptics-rmi4 - fix an unchecked out of memory error path



When extending the rmi_spi buffers, we must check that no out of memory
error occurs, otherwise we may access data above the currently allocated
memory.

Propagate the error code returned by 'rmi_spi_manage_pools()' instead.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Andrew Duggan <aduggan@synaptics.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

parent 664b0bae

drivers/input/rmi4/rmi_spi.c

+5 −2

Original line number	Diff line number	Diff line
		@@ -147,8 +147,11 @@ static int rmi_spi_xfer(struct rmi_spi_xport *rmi_spi,
		if (len > RMI_SPI_XFER_SIZE_LIMIT)
		return -EINVAL;

		if (rmi_spi->xfer_buf_size < len)
		rmi_spi_manage_pools(rmi_spi, len);
		if (rmi_spi->xfer_buf_size < len) {
		ret = rmi_spi_manage_pools(rmi_spi, len);
		if (ret < 0)
		return ret;
		}

		if (addr == 0)
		/*