Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 83957bc3 authored by Dedy Lansky's avatar Dedy Lansky Committed by Kalle Valo
Browse files

wil6210: remove leftover "FIXME"s 



"FIXME: IRQ mask debug" and "FIXME: interrupts enabled - for debug"
can be removed because wil6210_debug_irq_mask() is now considered
production feature.

"FIXME FW can transmit only ucast frames to peer" and "FIXME real
ring_id instead of hard coded 0" can be removed because FW/HW already
support multicast transmission.

Signed-off-by: default avatarDedy Lansky <qca_dlansky@qca.qualcomm.com>
Signed-off-by: default avatarMaya Erez <qca_merez@qca.qualcomm.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent a8fd16d7

drivers/net/wireless/ath/wil6210/interrupt.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -565,7 +565,7 @@ static irqreturn_t wil6210_hardirq(int irq, void *cookie) 
	if (unlikely((pseudo_cause == 0) || ((pseudo_cause & 0xff) == 0xff)))

	if (unlikely((pseudo_cause == 0) || ((pseudo_cause & 0xff) == 0xff)))

		return IRQ_NONE;

		return IRQ_NONE;





	/* FIXME: IRQ mask debug */

	/* IRQ mask debug */

	if (unlikely(wil6210_debug_irq_mask(wil, pseudo_cause)))

	if (unlikely(wil6210_debug_irq_mask(wil, pseudo_cause)))

		return IRQ_NONE;

		return IRQ_NONE;

drivers/net/wireless/ath/wil6210/wil6210.h

+1 −1
Original line number Original line Diff line number Diff line
@@ -439,7 +439,7 @@ enum { /* for wil6210_priv.status */ 
	wil_status_fwconnected,

	wil_status_fwconnected,

	wil_status_dontscan,

	wil_status_dontscan,

	wil_status_mbox_ready, /* MBOX structures ready */

	wil_status_mbox_ready, /* MBOX structures ready */

	wil_status_irqen, /* FIXME: interrupts enabled - for debug */

	wil_status_irqen, /* interrupts enabled - for debug */

	wil_status_napi_en, /* NAPI enabled protected by wil->mutex */

	wil_status_napi_en, /* NAPI enabled protected by wil->mutex */

	wil_status_resetting, /* reset in progress */

	wil_status_resetting, /* reset in progress */

	wil_status_suspending, /* suspend in progress */

	wil_status_suspending, /* suspend in progress */

drivers/net/wireless/ath/wil6210/wmi.c

+0 −2
Original line number Original line Diff line number Diff line
@@ -813,8 +813,6 @@ static void wmi_evt_connect(struct wil6210_priv *wil, int id, void *d, int len) 
		}

		}

	}

	}





	/* FIXME FW can transmit only ucast frames to peer */

	/* FIXME real ring_id instead of hard coded 0 */

	ether_addr_copy(wil->sta[evt->cid].addr, evt->bssid);

	ether_addr_copy(wil->sta[evt->cid].addr, evt->bssid);

	wil->sta[evt->cid].status = wil_sta_conn_pending;

	wil->sta[evt->cid].status = wil_sta_conn_pending;