Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 82d69203 authored by Daniel Jurgens's avatar Daniel Jurgens Committed by David S. Miller
Browse files

net/mlx4_en: Fix endianness bug in IPV6 csum calculation 



Use htons instead of unconditionally byte swapping nexthdr.  On a little
endian systems shifting the byte is correct behavior, but it results in
incorrect csums on big endian architectures.

Fixes: f8c6455b ('net/mlx4_en: Extend checksum offloading by CHECKSUM COMPLETE')
Signed-off-by: default avatarDaniel Jurgens <danielj@mellanox.com>
Reviewed-by: default avatarCarol Soto <clsoto@us.ibm.com>
Tested-by: default avatarCarol Soto <clsoto@us.ibm.com>
Signed-off-by: default avatarTariq Toukan <tariqt@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c2cf530d

drivers/net/ethernet/mellanox/mlx4/en_rx.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -707,7 +707,7 @@ static int get_fixed_ipv6_csum(__wsum hw_checksum, struct sk_buff *skb, 




	if (ipv6h->nexthdr == IPPROTO_FRAGMENT || ipv6h->nexthdr == IPPROTO_HOPOPTS)

	if (ipv6h->nexthdr == IPPROTO_FRAGMENT || ipv6h->nexthdr == IPPROTO_HOPOPTS)

		return -1;

		return -1;

	hw_checksum = csum_add(hw_checksum, (__force __wsum)(ipv6h->nexthdr << 8));

	hw_checksum = csum_add(hw_checksum, (__force __wsum)htons(ipv6h->nexthdr));





	csum_pseudo_hdr = csum_partial(&ipv6h->saddr,

	csum_pseudo_hdr = csum_partial(&ipv6h->saddr,

				       sizeof(ipv6h->saddr) + sizeof(ipv6h->daddr), 0);

				       sizeof(ipv6h->saddr) + sizeof(ipv6h->daddr), 0);