Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 82cea533 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Boris Brezillon
Browse files

mtd: onenand: omap2: print resource using %pR format string 



The omap2 onenand driver is now available for compile-testing, which
uncovers a warning in configurations that have a 64-bit resource_size_t:

drivers/mtd/onenand/omap2.c: In function 'omap2_onenand_probe':
drivers/mtd/onenand/omap2.c:536:54: error: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'resource_size_t {aka long long unsigned int}' [-Werror=format=]
   dev_err(dev, "Cannot reserve memory region at 0x%08x, size: 0x%x\n",
drivers/mtd/onenand/omap2.c:536:66: error: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'resource_size_t {aka long long unsigned int}' [-Werror=format=]

Changing the format string to the special %pR simplifies the code
and lets it do the right thing in that configuration, while avoiding
the warning.

Fixes: a758f50f ("mtd: onenand: omap2: Configure driver from DT")
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Reviewed-by: default avatarSebastian Reichel <sebastian.reichel@collabora.co.uk>
Reviewed-by: default avatarPeter Ujfalusi <peter.ujfalusi@ti.com>
Signed-off-by: default avatarBoris Brezillon <boris.brezillon@free-electrons.com>
parent 6837befd

drivers/mtd/onenand/omap2.c

+1 −2
Original line number Diff line number Diff line
@@ -533,8 +533,7 @@ static int omap2_onenand_probe(struct platform_device *pdev) 


	c->onenand.base = devm_ioremap_resource(dev, res);

	if (IS_ERR(c->onenand.base)) {

		dev_err(dev, "Cannot reserve memory region at 0x%08x, size: 0x%x\n",

			res->start, resource_size(res));

		dev_err(dev, "Cannot reserve memory region %pR\n", res);

		return PTR_ERR(c->onenand.base);

	}