Commit 82c6544d authored Jun 10, 2016 by John Crispin Committed by David S. Miller Jun 10, 2016

net: mediatek: remove superfluous queue wake up call



The code checks if the queue should be stopped because we are below the
threshold of free descriptors only to check if it should be started again.
If we do end up in a state where we are at the threshold limit, it makes
more sense to just stop the queue and wait for the next IRQ to trigger the
TX housekeeping again. There is no rush in enqueuing the next packet, it
needs to wait for all the others in the queue to be dispatched first
anyway.

Signed-off-by: John Crispin <john@phrozen.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent ad3cba98

drivers/net/ethernet/mediatek/mtk_eth_soc.c

+2 −5

Original line number	Diff line number	Diff line
		@@ -783,12 +783,9 @@ static int mtk_start_xmit(struct sk_buff skb, struct net_device dev)
		if (mtk_tx_map(skb, dev, tx_num, ring, gso) < 0)
		goto drop;

		if (unlikely(atomic_read(&ring->free_count) <= ring->thresh)) {
		if (unlikely(atomic_read(&ring->free_count) <= ring->thresh))
		mtk_stop_queue(eth);
		if (unlikely(atomic_read(&ring->free_count) >
		ring->thresh))
		mtk_wake_queue(eth);
		}

		spin_unlock_irqrestore(&eth->page_lock, flags);

		return NETDEV_TX_OK;