Commit 825b8650 authored May 27, 2018 by Colin Ian King Committed by Mimi Zohar May 31, 2018

EVM: fix memory leak of temporary buffer 'temp'

The allocation of 'temp' is not kfree'd and hence there is a memory
leak on each call of evm_read_xattrs. Fix this by kfree'ing it
after copying data from it back to the user space buffer 'buf'.

Detected by CoverityScan, CID#1469386 ("Resource Leak")

Fixes: fa516b66 ("EVM: Allow runtime modification of the set of verified xattrs")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Mimi Zohar <zohar@linux.vnet.ibm.com>

parent 53b626f9

security/integrity/evm/evm_secfs.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -158,6 +158,8 @@ static ssize_t evm_read_xattrs(struct file filp, char __user buf,
		mutex_unlock(&xattr_list_mutex);
		rc = simple_read_from_buffer(buf, count, ppos, temp, strlen(temp));

		kfree(temp);

		return rc;
		}