Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 82167cb8 authored by viresh kumar's avatar viresh kumar Committed by David S. Miller
Browse files

net: dsa/slave: Fix compilation warnings



Currently when none of CONFIG_NET_DSA_TAG_DSA, CONFIG_NET_DSA_TAG_EDSA and
CONFIG_NET_DSA_TAG_TRAILER is defined, we get following compilation warnings:

net/dsa/slave.c:51:12: warning: 'dsa_slave_init' defined but not used [-Wunused-function]
net/dsa/slave.c:60:12: warning: 'dsa_slave_open' defined but not used [-Wunused-function]
net/dsa/slave.c:98:12: warning: 'dsa_slave_close' defined but not used [-Wunused-function]
net/dsa/slave.c:116:13: warning: 'dsa_slave_change_rx_flags' defined but not used [-Wunused-function]
net/dsa/slave.c:127:13: warning: 'dsa_slave_set_rx_mode' defined but not used [-Wunused-function]
net/dsa/slave.c:136:12: warning: 'dsa_slave_set_mac_address' defined but not used [-Wunused-function]
net/dsa/slave.c:164:12: warning: 'dsa_slave_ioctl' defined but not used [-Wunused-function]

Earlier approach to fix this was discussed here:

lkml.org/lkml/2012/10/29/549

This is another approach to fix it. This is done by some changes in config
options, which make more sense than the earlier approach. As, atleast one
tagging option must always be selected for using net/dsa/ infrastructure, this
patch selects NET_DSA from tagging configs instead of having it as an selectable
config.

Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent a303fbf3
Loading
Loading
Loading
Loading
+0 −1
Original line number Diff line number Diff line
menu "Distributed Switch Architecture drivers"
	depends on NET_DSA

config NET_DSA_MV88E6XXX
	tristate
+9 −7
Original line number Diff line number Diff line
config NET_DSA
	tristate "Distributed Switch Architecture support"
	tristate
	default n
	depends on EXPERIMENTAL && NETDEVICES && !S390
	select PHYLIB
@@ -8,19 +8,21 @@ config NET_DSA
	  the Distributed Switch Architecture.


if NET_DSA
menu "Distributed Switch Architecture support"

# tagging formats
config NET_DSA_TAG_DSA
	bool
	bool "Original DSA packet tagging format"
	select NET_DSA
	default n

config NET_DSA_TAG_EDSA
	bool
	bool "Ethertype DSA packet tagging format"
	select NET_DSA
	default n

config NET_DSA_TAG_TRAILER
	bool
	bool "Trailer DSA packet tagging format"
	select NET_DSA
	default n

endif
endmenu