Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Unverified Commit 81b3cc55 authored by Sergej Sawazki's avatar Sergej Sawazki Committed by Mark Brown
Browse files

ASoC: wm8741: Fix setting BCLK and LRCLK polarity 



After checking the code and the datasheet, it seems like we are handling
the clock inversion (SND_SOC_DAIFMT_NB_IF and SND_SOC_DAIFMT_IB_IF) not
correctly.

>From the datasheet (Table 58):
R5 Format Control, BITS[5:4], [BCP:LRP]:
  (0) 00 =  normal   BCLK, normal   LRCLK
  (1) 01 =  normal   BCLK, inverted LRCLK <-- Fix this
  (2) 10 =  inverted BCLK, normal   LRCLK
  (3) 11 =  inverted BCLK, inverted LRCLK <-- Fix this

Signed-off-by: default avatarSergej Sawazki <sergej@taudac.com>
Acked-by: default avatarCharles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent eaf8abcf

sound/soc/codecs/wm8741.c

+2 −2
Original line number Diff line number Diff line
@@ -333,13 +333,13 @@ static int wm8741_set_dai_fmt(struct snd_soc_dai *codec_dai, 
	switch (fmt & SND_SOC_DAIFMT_INV_MASK) {

	case SND_SOC_DAIFMT_NB_NF:

		break;

	case SND_SOC_DAIFMT_IB_IF:

	case SND_SOC_DAIFMT_NB_IF:

		iface |= 0x10;

		break;

	case SND_SOC_DAIFMT_IB_NF:

		iface |= 0x20;

		break;

	case SND_SOC_DAIFMT_NB_IF:

	case SND_SOC_DAIFMT_IB_IF:

		iface |= 0x30;

		break;

	default: