Commit 813a23e0 authored May 08, 2021 by Zhen Lei Committed by Greg Kroah-Hartman Jun 10, 2021

ieee802154: fix error return code in ieee802154_add_iface()



[ Upstream commit 79c6b8ed30e54b401c873dbad2511f2a1c525fd5 ]

Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: be51da0f ("ieee802154: Stop using NLA_PUT*().")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Link: https://lore.kernel.org/r/20210508062517.2574-1-thunder.leizhen@huawei.com


Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 8aed10cd

net/ieee802154/nl-phy.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -249,8 +249,10 @@ int ieee802154_add_iface(struct sk_buff skb, struct genl_info info)
		}

		if (nla_put_string(msg, IEEE802154_ATTR_PHY_NAME, wpan_phy_name(phy)) \|\|
		nla_put_string(msg, IEEE802154_ATTR_DEV_NAME, dev->name))
		nla_put_string(msg, IEEE802154_ATTR_DEV_NAME, dev->name)) {
		rc = -EMSGSIZE;
		goto nla_put_failure;
		}
		dev_put(dev);

		wpan_phy_put(phy);