Commit 8128a31e authored May 08, 2017 by Dan Carpenter Committed by Linus Torvalds May 08, 2017

drivers/misc/c2port/c2port-duramar2150.c: checking for NULL instead of IS_ERR()

c2port_device_register() never returns NULL, it uses error pointers.

Link: http://lkml.kernel.org/r/20170412083321.GC3250@mwanda


Fixes: 65131cd5 ("c2port: add c2port support for Eurotech Duramar 2150")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Rodolfo Giometti <giometti@linux.it>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 146180c0

drivers/misc/c2port/c2port-duramar2150.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -129,8 +129,8 @@ static int __init duramar2150_c2port_init(void)

		duramar2150_c2port_dev = c2port_device_register("uc",
		&duramar2150_c2port_ops, NULL);
		if (!duramar2150_c2port_dev) {
		ret = -ENODEV;
		if (IS_ERR(duramar2150_c2port_dev)) {
		ret = PTR_ERR(duramar2150_c2port_dev);
		goto free_region;
		}