Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 81198078 authored by Xiaoyan Zhang's avatar Xiaoyan Zhang Committed by James Morris
Browse files

driver/char/tpm: declare internal symbols as static 



This patch declares the internal struct and functions as static to provide
more security.

Signed-off-by: default avatarXiaoyan Zhang <xiaoyan.zhang@intel.com>
Signed-off-by: default avatarFengguang Wu <fengguang.wu@intel.com>
Reviewed-by: default avatarKent Yoder <key@linux.vnet.ibm.com>
Signed-off-by: default avatarJames Morris <james.l.morris@oracle.com>
parent f84fdff0

drivers/char/tpm/tpm.c

+2 −2
Original line number Diff line number Diff line
@@ -915,7 +915,7 @@ EXPORT_SYMBOL_GPL(tpm_show_pcrs); 


#define  READ_PUBEK_RESULT_SIZE 314

#define TPM_ORD_READPUBEK cpu_to_be32(124)

struct tpm_input_header tpm_readpubek_header = {

static struct tpm_input_header tpm_readpubek_header = {

	.tag = TPM_TAG_RQU_COMMAND,

	.length = cpu_to_be32(30),

	.ordinal = TPM_ORD_READPUBEK
@@ -1395,7 +1395,7 @@ EXPORT_SYMBOL_GPL(tpm_dev_vendor_release); 
 * Once all references to platform device are down to 0,

 * release all allocated structures.

 */

void tpm_dev_release(struct device *dev)

static void tpm_dev_release(struct device *dev)

{

	struct tpm_chip *chip = dev_get_drvdata(dev);

drivers/char/tpm/tpm_ppi.c

+19 −18
Original line number Diff line number Diff line
@@ -53,8 +53,8 @@ static inline void ppi_assign_params(union acpi_object params[4], 
	params[3].package.elements = NULL;

}



ssize_t tpm_show_ppi_version(struct device *dev, struct device_attribute *attr,

			     char *buf)

static ssize_t tpm_show_ppi_version(struct device *dev,

				    struct device_attribute *attr, char *buf)

{

	acpi_handle handle;

	acpi_status status;
@@ -82,9 +82,8 @@ ssize_t tpm_show_ppi_version(struct device *dev, struct device_attribute *attr, 
	return status;

}



ssize_t tpm_show_ppi_request(struct device *dev,

			     struct device_attribute *attr,

			     char *buf)

static ssize_t tpm_show_ppi_request(struct device *dev,

				    struct device_attribute *attr, char *buf)

{

	acpi_handle handle;

	acpi_status status;
@@ -132,7 +131,7 @@ ssize_t tpm_show_ppi_request(struct device *dev, 
	return status;

}



ssize_t tpm_store_ppi_request(struct device *dev,

static ssize_t tpm_store_ppi_request(struct device *dev,

				     struct device_attribute *attr,

				     const char *buf, size_t count)

{
@@ -207,7 +206,7 @@ ssize_t tpm_store_ppi_request(struct device *dev, 
	return status;

}



ssize_t tpm_show_ppi_transition_action(struct device *dev,

static ssize_t tpm_show_ppi_transition_action(struct device *dev,

					      struct device_attribute *attr,

					      char *buf)

{
@@ -269,7 +268,7 @@ ssize_t tpm_show_ppi_transition_action(struct device *dev, 
	return status;

}



ssize_t tpm_show_ppi_response(struct device *dev,

static ssize_t tpm_show_ppi_response(struct device *dev,

				     struct device_attribute *attr,

				     char *buf)

{
@@ -413,14 +412,16 @@ static ssize_t show_ppi_operations(char *buf, u32 start, u32 end) 
	return str - buf;

}



ssize_t tpm_show_ppi_tcg_operations(struct device *dev,

				   struct device_attribute *attr, char *buf)

static ssize_t tpm_show_ppi_tcg_operations(struct device *dev,

					   struct device_attribute *attr,

					   char *buf)

{

	return show_ppi_operations(buf, 0, PPI_TPM_REQ_MAX);

}



ssize_t tpm_show_ppi_vs_operations(struct device *dev,

				  struct device_attribute *attr, char *buf)

static ssize_t tpm_show_ppi_vs_operations(struct device *dev,

					  struct device_attribute *attr,

					  char *buf)

{

	return show_ppi_operations(buf, PPI_VS_REQ_START, PPI_VS_REQ_END);

}