Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 809cb695 authored Jan 03, 2018 by Alex Estrin Committed by Jason Gunthorpe Jan 03, 2018

IB/ipoib: Fix for notify send CQ failure messages



If IB_CQ_REPORT_MISSED_EVENTS flag is passed in ib_req_notify_cq()
it may return positive value indicating non-empty CQ.
If return code not verified the log might be flooded with false
warning messages "request notify on send CQ failed".

Fixes: 8966e28d ("IB/ipoib: Use NAPI in UD/TX flows")
Reviewed-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
Signed-off-by: Alex Estrin <alex.estrin@intel.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

parent e48e5e19

drivers/infiniband/ulp/ipoib/ipoib_cm.c

+6 −4

Original line number	Diff line number	Diff line
		@@ -766,10 +766,12 @@ void ipoib_cm_send(struct net_device dev, struct sk_buff skb, struct ipoib_cm_
		skb_orphan(skb);
		skb_dst_drop(skb);

		if (netif_queue_stopped(dev))
		if (ib_req_notify_cq(priv->send_cq, IB_CQ_NEXT_COMP \|
		IB_CQ_REPORT_MISSED_EVENTS)) {
		if (netif_queue_stopped(dev)) {
		rc = ib_req_notify_cq(priv->send_cq, IB_CQ_NEXT_COMP \|
		IB_CQ_REPORT_MISSED_EVENTS);
		if (unlikely(rc < 0))
		ipoib_warn(priv, "IPoIB/CM:request notify on send CQ failed\n");
		else if (rc)
		napi_schedule(&priv->send_napi);
		}

drivers/infiniband/ulp/ipoib/ipoib_ib.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -644,7 +644,7 @@ int ipoib_send(struct net_device dev, struct sk_buff skb,

		if (netif_queue_stopped(dev))
		if (ib_req_notify_cq(priv->send_cq, IB_CQ_NEXT_COMP \|
		IB_CQ_REPORT_MISSED_EVENTS))
		IB_CQ_REPORT_MISSED_EVENTS) < 0)
		ipoib_warn(priv, "request notify on send CQ failed\n");

		rc = post_send(priv, priv->tx_head & (ipoib_sendq_size - 1),