Commit 7f59ebb5 authored Jun 18, 2012 by Dan Carpenter Committed by John W. Linville Jun 19, 2012

airo: copying wrong data in airo_get_aplist()



"qual" used to be declared on the stack, but then in 998a5a7d ("airo:
reduce stack memory footprint") we made it dynamically allocated.
Unfortunately the memcpy() here was missed and it's still copying stack
memory instead of the data that we want.  In other words, "&qual" should
be "qual".

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

parent 73dc3b90

drivers/net/wireless/airo.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -7233,8 +7233,8 @@ static int airo_get_aplist(struct net_device *dev,
		}
		} else {
		dwrq->flags = 1; /* Should be define'd */
		memcpy(extra + sizeof(struct sockaddr)*i,
		&qual, sizeof(struct iw_quality)*i);
		memcpy(extra + sizeof(struct sockaddr) * i, qual,
		sizeof(struct iw_quality) * i);
		}
		dwrq->length = i;